search

digdir / designsystemet

Designsystemet
https://designsystemet.no
MIT License
68 stars 34 forks source link

feat(theme): 🎨 apps/theme enabled in all linters #2101

Closed poi33 closed 3 weeks ago

poi33 commented 1 month ago

Fix for #2005

Included apps/theme in tsconfig root Extended apps/theme tsconfig to include the root tsconfig Fixed eslint errors/warnings No longer ignore apps/theme in stylelintignore Fixed stylelint errors

mimarz commented 4 weeks ago

Sorry, we didn't flag the issue correctly but we have done a lot of these changes and other for the upcoming release of V1. We've been in crunch for quite some time so not all is updated yet everywhere.

All the changes that have been done that regards is in the next branch. I changed the target for you on this PR to check how many conflict would occur.

Apologise for the wasted work 🙈 Either way, thanks for the effort! 👏

poi33 commented 4 weeks ago

@mimarz thats okay. I will like to see what i did is even close to the next branch.

mimarz commented 4 weeks ago

@mimarz thats okay. I will like to see what i did is even close to the next branch.

Alrighty. We haven't sorted out all our environments yet. Going forward next will be the development branch and main be whats currently published to production/(@latest). Plan is to also introduce more automated CI, so whats on next will automatically be published to for example next.storybook.designsystemet.no and @digdir/designsystemet-react@next

mimarz commented 3 weeks ago

Can we close this or did you want to look at it more? @poi33 ?

poi33 commented 3 weeks ago

Yeah, I'll close it. Its not going to contribute much