digdir / designsystemet

Designsystemet
https://designsystemet.no
MIT License
74 stars 37 forks source link

Review `Group` components for V1 #2331

Open eirikbacker opened 4 weeks ago

eirikbacker commented 4 weeks ago

ButtonGroup (missing today but located in Figma), ChipGroup, TagGroup, etc - they are really just simple display: flex containers (super easy to implement). I think we should perhaps remove ChipGroup from our code for now since it is the only component that offers such a container, and it could actually in the future might be better to use a shared Primitive component rather than individual components replicating code? In our current documentation, we for instance have examples of buttons next to each other, without providing a ButtonGroup component, so for consistency, I suggest we allow ourselves to do the same on Chip as well. What do you think? ☺

eirikbacker commented 3 weeks ago

Related to #2321

mimarz commented 5 days ago

Related to #2304