Should Search become part of Input component with type=search?

digdir / designsystemet

Designsystemet

https://designsystemet.no

MIT License

78 stars 36 forks source link

Should Search become part of Input component with type=search? #2388

Open eirikbacker opened 1 month ago

eirikbacker commented 1 month ago

Input type="search" is a native input anyway- meaning we can add x to clear and icon automatically
Textfield is a native input anyway
Button after search can be added as a suffix with Input.Adornments element (as discussed in #2311)

Barsnes commented 1 month ago

Search already has type="search". Are you suggesting dropping the Search component? It has different variants, which makes it more difficult to just append to our Textfield

eirikbacker commented 1 month ago

Yes; suggesting to remove the component, and rather make the Search button a suffix for Input - rather show example stories on how to combine a button and input instead of making a custom component :)

Barsnes commented 1 month ago

This was mentioned in #2221, and should probably be a part of that issue. See comment: https://github.com/digdir/designsystemet/issues/2221#issuecomment-2293318663

mimarz commented 3 weeks ago

Suggest we revisit this after #2311