digdir / designsystemet

Designsystemet
https://designsystemet.no
MIT License
85 stars 38 forks source link

refactor(Field): :recycle: merge `CharacterCounter` into `Field` #2717

Closed mimarz closed 1 month ago

mimarz commented 1 month ago
changeset-bot[bot] commented 1 month ago

⚠️ No Changeset found

Latest commit: 73896f0f0f3a1798e8f5768095458d4f13934395

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

github-actions[bot] commented 1 month ago

Preview deployments for this pull request:

Storybook - 1. Nov 2024 - 12:19

github-actions[bot] commented 1 month ago

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 55.43% 3274 / 5906
🔵 Statements 55.43% 3274 / 5906
🔵 Functions 84.65% 171 / 202
🔵 Branches 74.14% 479 / 646
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
packages/react/src/components/form/Field/FieldCounter.tsx 14.63% 100% 0% 14.63% 21, 25-31, 33-41, 43, 45, 47-48, 50-56, 58-63, 65
Generated in workflow #730 for commit 73896f0 by the Vitest Coverage Report Action
mimarz commented 1 month ago

Looks like you forgot to export FieldCounter in the index file

fixed!