search

digdir / dialogporten-frontend

Brukergrensesnitt for Dialogporten
https://digdir.github.io/dialogporten-frontend/
MIT License
4 stars 2 forks source link

chore: Playwright test for savedSearch. Added organizations mocking. … #1301

Closed alexdigdir closed 1 month ago

alexdigdir commented 1 month ago

…Fixed formatting.

Hva er endret?

Dokumentasjon / Storybook / testdekning

Skjermbilder eller GIFs (valgfritt)

Summary by CodeRabbit

Release Notes

coderabbitai[bot] commented 1 month ago
📝 Walkthrough
📝 Walkthrough ## Walkthrough The pull request introduces several modifications across multiple files, primarily focusing on enhancing error handling in the `Html` and `Markdown` components by setting default values for their `onError` props. Additionally, it includes the integration of organization data into the mocked data retrieval process, along with various formatting improvements in several TypeScript files. A new mock handler for fetching organizations is added, and a new test suite for saved searches is introduced. The `tsconfig.json` file is also updated to limit TypeScript compilation to the `src` directory. ## Changes | File | Change Summary | |------|----------------| | `packages/embeddable-markdown-html/src/html.tsx` | Updated `Html` component to set default `onError` prop to `() => {}`. | | `packages/embeddable-markdown-html/src/markdown.tsx` | Updated `Markdown` component to set default `onError` prop to `() => {}`. | | `packages/frontend/src/mocks/data.ts` | Enhanced `getMockedData` function to include `organizations` in the returned object; reformatted `findDataById` function. | | `packages/frontend/src/mocks/data/base/organizations.ts` | Introduced `organizations.ts` file exporting an array of organization objects. | | `packages/frontend/src/mocks/data/base/profile.ts` | Minor formatting changes; no functional changes. | | `packages/frontend/src/mocks/data/stories/english-1/parties.ts` | Added trailing comma in `parties` array for formatting consistency. | | `packages/frontend/src/mocks/data/stories/english-1/profile.ts` | Minor formatting changes; no functional changes. | | `packages/frontend/src/mocks/handlers.ts` | Added `organizations` to `inMemoryStore` and new GraphQL handler `getOrganizationsMock`; improved formatting in existing handlers. | | `packages/frontend/tests/smoke.spec.ts` | Removed shared `beforeEach` navigation to `appURL`; navigation now occurs within individual tests. | | `packages/frontend/tests/stories/savedSearch.spec.ts` | Introduced new test suite for saved search functionality. | | `packages/frontend/tsconfig.json` | Updated `include` property to limit TypeScript compilation to `src` directory. | ## Possibly related PRs - **#1137**: The changes in the `Markdown` component include the addition of a `classMap` parameter, which relates to the `Html` component's error handling improvements in the main PR, as both components are part of the `embeddable-markdown-html` package and involve rendering content. - **#1231**: The introduction of the `AdditionalInfoContent` component in this PR enhances the rendering capabilities for different media types, which is related to the changes in the `Html` component that also deals with rendering content and error handling. - **#1284**: The modifications to the `SaveSearchButton` component include improvements in handling saved searches, which may indirectly relate to the overall error handling and user feedback mechanisms enhanced in the main PR's `Html` component. - **#1291**: The refactoring of MSW handlers to improve flexibility in mocking data is relevant as it supports the overall structure and error handling improvements made in the main PR, particularly in how components interact with mocked data. - **#1294**: The addition of the `deleteSavedSearchMock` handler for mocking delete actions aligns with the main PR's focus on improving error handling and user feedback, as both involve managing application state and user interactions effectively. ## Suggested labels `dev` ## Suggested reviewers - seanes
📜 Recent review details **Configuration used: .coderabbit.yaml** **Review profile: CHILL**
📥 Commits Files that changed from the base of the PR and between 0f4cf73ff5c41910f6b46bfcd02318a6bf1166fa and 128afc68e2dd0eaee70d5fe816e0cd9dbdc070bf.
📒 Files selected for processing (2) * packages/embeddable-markdown-html/tests/html.spec.tsx (1 hunks) * packages/embeddable-markdown-html/tests/markdown.spec.tsx (1 hunks)
✅ Files skipped from review due to trivial changes (2) * packages/embeddable-markdown-html/tests/html.spec.tsx * packages/embeddable-markdown-html/tests/markdown.spec.tsx
--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.