search

digdir / dialogporten-frontend

Brukergrensesnitt for Dialogporten
https://digdir.github.io/dialogporten-frontend/
MIT License
4 stars 2 forks source link

fix: Searchbar results. Added pre push tests. #1329

Closed alexdigdir closed 3 weeks ago

alexdigdir commented 3 weeks ago

Hva er endret?

Dokumentasjon / Storybook / testdekning

Skjermbilder eller GIFs (valgfritt)

Summary by CodeRabbit

coderabbitai[bot] commented 3 weeks ago
📝 Walkthrough ## Walkthrough The pull request introduces modifications to the `useEffect` hook in the `useDialogs` API and updates the `SearchDropdown` component to utilize `selectedParties` instead of `parties`. The dependency array of the `useEffect` now includes `parties` and `organizations`, enhancing the effect's responsiveness to changes in these variables. The `SearchDropdown` component's data flow is altered to ensure that only selected parties are considered in the search process, while the overall structure and rendering logic remain unchanged. ## Changes | File | Change Summary | |----------------------------------------------|--------------------------------------------------------------------------------------------------------| | `packages/frontend/src/api/useDialogs.tsx` | Updated the dependency array of the `useEffect` hook in `useSearchDialogs` to include `parties` and `organizations`. | | `packages/frontend/src/components/Header/SearchDropdown.tsx` | Changed the data retrieval from `useParties` to `selectedParties`, affecting the argument passed to `useSearchDialogs`. | ## Possibly related PRs - **#1201**: Modifications to the `useParties` hook related to handling party data, directly connected to the `useSearchDialogs` function. - **#1310**: Enhancements to the `useParties` hook to clear filters when a party is selected, relevant to the changes in the `useEffect` hook's dependency array. - **#1328**: Modifications to the `useParties` hook regarding query parameters for party selection, aligning with the main PR's enhancements for responsiveness to `parties`. ## Suggested labels `dev` ## Suggested reviewers - seanes
📜 Recent review details **Configuration used: .coderabbit.yaml** **Review profile: CHILL**
📥 Commits Reviewing files that changed from the base of the PR and between f0f392e83aa81ad6c93c2d6a529e26fdf625d056 and 9668b9c05d30bbe63def8e8e7d4deb05d741858b.
📒 Files selected for processing (1) * `packages/frontend/src/components/Header/SearchDropdown.tsx` (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1) * packages/frontend/src/components/Header/SearchDropdown.tsx

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
alexdigdir commented 3 weeks ago

Why should we add pre push hook when we already have a hook for this on pre commit? I don't want to run all these operations on all frontend files when I run a commit. Only on stages files, and not only for frontend.

I was not aware of an already existing pre-commit hook that does this, only (optional) pre-commit hook I can find runs pnpm lint-staged -- --color only.

The tests in this PR are already only running on frontend, running tests in the /packages/frontend/tests folder: `echo "Running Playwright tests..."

pnpm --filter frontend test:playwright

echo "Running typechecking..."

pnpm --filter frontend typecheck`

But I guess everything has to be 100% how you want it or it will never get merged to main, so I will remove all hooks and update PR.

seanes commented 3 weeks ago

But combining a bug fix with a change to a developer experience (Added pre push hook, running Playwright tests and Typescript checks) without having discussed the problem, is probably not optimal, don't you agree?

We should definitely find an agreement what suits best for all devs in the team, and I think it's better to address this in a separate issue / pull request.