search

digdir / dialogporten-frontend

Brukergrensesnitt for Dialogporten
https://digdir.github.io/dialogporten-frontend/
MIT License
4 stars 2 forks source link

chore: Adding NoConsoleLog rule to Biome linter #1348

Closed alexdigdir closed 1 week ago

alexdigdir commented 2 weeks ago

Hva er endret?

Dokumentasjon / Storybook / testdekning

Skjermbilder eller GIFs (valgfritt)

Summary by CodeRabbit

coderabbitai[bot] commented 2 weeks ago
📝 Walkthrough
📝 Walkthrough ## Walkthrough The pull request introduces changes to multiple files, primarily focusing on the `biome.jsonc` configuration file, where a new linter rule `noConsoleLog` is added under the `suspicious` category with its level set to "error". The existing rule `noArrayIndexKey` is set to "off". Additionally, the `package.json` file is updated to change the version of the `@biomejs/biome` package from `1.9.2` to `1.9.4`. A new shell script file `.hooks/pre-push` is also added to run linting checks before pushing changes. ## Changes | File | Change Summary | |-------------------------------------------|-------------------------------------------------------------------------------------------------------------| | biome.jsonc | Added new linter rule `noConsoleLog` with level set to "error" in `linter.rules.suspicious`; set `noArrayIndexKey` to "off". | | package.json | Updated version of `@biomejs/biome` from `1.9.2` to `1.9.4` in `devDependencies`. | | .hooks/pre-push | Created new file to execute `pnpm lint-staged -- --color` when triggered. | | packages/docusaurus-tldraw-plugin/src/tldr.jsx | Changed error logging from `console.log` to `console.error` for improved error visibility. | | packages/frontend/src/analytics.ts | Replaced `console.log` with `console.info` for successful initialization logging of Application Insights. | | packages/frontend/src/auth/api.ts | Changed error logging from `console.log` to `console.error` in `getIsAuthenticated` function. | | packages/frontend/src/components/FilterBar/index.ts | Modified export statement for `Filter` type from `export { type Filter }` to `export type { Filter }`. | | packages/frontend/src/components/InboxItem/GuiActions.tsx | Changed error logging from `console.log` to `console.error` in `handleButtonClick`; updated `GuiActionsProps` interface. | | packages/frontend/src/main.tsx | Updated logging method from `console.log` to `console.error` for missing "root" element. | | packages/storybook/src/stories/GuiActions/guiActions.stories.tsx | Changed logging from `console.log` to `console.info` in `onDeleteSuccess` callback. |
## Possibly related PRs - **#1125**: Modifications to the `useDialogs.tsx` file, updating console logging, related to the new `noConsoleLog` rule. - **#1123**: Removal of a console log statement in `useDialogs.tsx`, relevant to the enforcement of the `noConsoleLog` rule. - **#1130**: Changes in `useDialogs.tsx` regarding error logging, aligning with the introduction of the `noConsoleLog` rule. - **#1300**: Enhancements to `GuiActions.tsx` for user experience, contributing to better coding practices. - **#1301**: Introduction of a Playwright test suite, contributing to overall quality assurance efforts. - **#1349**: Modifications to `.gitignore`, reflecting improvements in development practices. ## Suggested labels `dev` ## Suggested reviewers - seanes

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
seanes commented 2 weeks ago

Smeller på en del checks der, ja :thinking_face: Kanskje kun ha "error" på det som kjøres på lint-staged, og ikke ha det i global config?

f.eks. 

  "lint-staged": {
    "**/*.*": [
    "biome check --staged --no-errors-on-unmatched --write",
    "biome check --rule no-console --severity error"
    ]
  },

i packages/frontend/package.json?

Hva tenker du?