search

digdir / dialogporten-frontend

Brukergrensesnitt for Dialogporten
https://digdir.github.io/dialogporten-frontend/
MIT License
4 stars 2 forks source link

fix: Application freezing but when moving dialog to bin #1352

Closed alexdigdir closed 2 weeks ago

alexdigdir commented 2 weeks ago

Hva er endret?

Dokumentasjon / Storybook / testdekning

Skjermbilder eller GIFs (valgfritt)

Summary by CodeRabbit

coderabbitai[bot] commented 2 weeks ago
📝 Walkthrough
📝 Walkthrough
📝 Walkthrough
📝 Walkthrough ## Walkthrough The changes in this pull request involve modifications to the `AdditionalInfoContent`, `MainContentReference`, `Html`, and `Markdown` components across the frontend and embeddable-markdown-html packages. Both `AdditionalInfoContent` and `MainContentReference` components have been wrapped in React's `memo` function to optimize performance by preventing unnecessary re-renders when props remain unchanged. The `MainContentReference` component has also improved error handling for its `getContent` function. Additionally, the `Html` and `Markdown` components now require an `onError` prop, enforcing error handling by mandating that a handler must be provided. ## Changes | File Path | Change Summary | |-----------------------------------------------------|---------------------------------------------------------------------------------------------------------------------| | `.../AdditonalInfoContent/AdditonalInfoContent.tsx` | Wrapped `AdditionalInfoContent` in `memo` for performance optimization; updated export statement and error handling for `Html` and `Markdown`. | | `.../MainContentReference/MainContentReference.tsx` | Wrapped `MainContentReference` in `memo`; added error handling to `getContent` function; updated export statement. | | `.../embeddable-markdown-html/src/html.tsx` | Changed `onError` prop from optional to required in `Html` component. | | `.../embeddable-markdown-html/src/markdown.tsx` | Changed `onError` prop from optional to required in `Markdown` component. | | `.../Activity/Activity.tsx` | Simplified the nullish coalescing operation in `performedByName` variable assignment. | | `.../PartyDropdown/PartyDropdown.tsx` | Simplified the rendering logic of `ProfileButton` by removing parentheses around the conditional expression. | ## Possibly related PRs - **#1231**: The changes in the main PR regarding the `AdditionalInfoContent` component are directly related to this PR, which also modifies how additional information is rendered based on the media type, including support for HTML and markdown. - **#1301**: The modifications in the `Html` and `Markdown` components in this PR enhance error handling, which is relevant to the changes made in the main PR where error handling was added to the `Html` and `Markdown` components within the `AdditionalInfoContent`. ## Suggested reviewers - seanes

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
seanes commented 2 weeks ago

Foreslår at onError har en default-funksjon i komponenten Markdown, f.eks. "unable to parse markdown" eller noe, så kan du fjerne disse litt generiske / unødvendige MainContentReference. Hva tenker du om det?