fix(graphql): ensure gql has maskinporten environment set

arealmaas commented 2 weeks ago

Description

Related Issue(s)

{issue number}

Verification

[ ] Your code builds clean without any errors or warnings
[ ] Manual testing done (required)
[ ] Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

[ ] Documentation is updated (either in docs-directory, Altinnpedia or a separate linked PR in altinn-studio-docs., if applicable)

Summary by CodeRabbit

New Features
- Introduced a new configuration option, "TokenExchangeEnvironment," across multiple environments (development, production, staging, testing, and yt01) to enhance token exchange settings.
Bug Fixes
- Minor formatting adjustments made to the configuration files for improved clarity.

coderabbitai[bot] commented 2 weeks ago

[!CAUTION]

Review failed

The pull request is closed.

📝 Walkthrough

## Walkthrough The pull request introduces a new configuration key, `"TokenExchangeEnvironment"`, across multiple environment-specific JSON files within the `appsettings` directory. This key is added under the "Maskinporten" section, with different values assigned for development, staging, testing, production, and a specific environment. The existing structure of each JSON file remains unchanged, and no other keys or values are modified. ## Changes | File Path | Change Summary | |------------------------------------------------------|--------------------------------------------------------------| | `src/Digdir.Domain.Dialogporten.GraphQL/appsettings.Development.json` | Added `"TokenExchangeEnvironment": "tt02"` under "Maskinporten" | | `src/Digdir.Domain.Dialogporten.GraphQL/appsettings.prod.json` | Added `"TokenExchangeEnvironment": "prod"` under "Maskinporten" | | `src/Digdir.Domain.Dialogporten.GraphQL/appsettings.staging.json` | Added `"TokenExchangeEnvironment": "tt02"` under "Maskinporten" | | `src/Digdir.Domain.Dialogporten.GraphQL/appsettings.test.json` | Added `"TokenExchangeEnvironment": "tt02"` under "Maskinporten"; minor newline formatting change | | `src/Digdir.Domain.Dialogporten.GraphQL/appsettings.yt01.json` | Added `"TokenExchangeEnvironment": "yt01"` under "Maskinporten" | ## Possibly related PRs - #1328: This PR adds the `"TokenExchangeEnvironment"` key in the `appsettings` configuration files, which is directly related to the changes made in the main PR regarding the addition of the same key in multiple `appsettings` files. - #1329: This PR introduces a new `appsettings.yt01.json` file that includes settings for the `Maskinporten` section, which aligns with the changes in the main PR that also involve the `Maskinporten` configuration. ## Suggested reviewers - knuhau

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

🪧 Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.