feat(azure): enable query performance insights for postgres

arealmaas commented 2 weeks ago

Description

Sets the necessary server properties to enable Query Performance Insights
Enabled on Test, Staging and YT01
Minor refactor to make things a tad cleaner

Related Issue(s)

{issue number}

Verification

[ ] Your code builds clean without any errors or warnings
[ ] Manual testing done (required)
[ ] Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

[ ] Documentation is updated (either in docs-directory, Altinnpedia or a separate linked PR in altinn-studio-docs., if applicable)

Summary by CodeRabbit

New Features
- Introduced a new configuration structure for PostgreSQL with enhanced settings, including the ability to enable query performance insights.
- Added parameters to manage PostgreSQL SKU details more effectively.
Bug Fixes
- Resolved inconsistencies in PostgreSQL parameter definitions across multiple configuration files.
Documentation
- Updated documentation to reflect changes in PostgreSQL configuration management.

coderabbitai[bot] commented 2 weeks ago

[!WARNING]

Rate limit exceeded

@arealmaas has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 25 minutes and 20 seconds before requesting another review.

⌛ How to resolve this issue?
After the wait time has elapsed, a review can be triggered using the `@coderabbitai review` command as a PR comment. Alternatively, push new commits to this PR. We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?
CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our [FAQ](https://coderabbit.ai/docs/faq) for further information.

📥 Commits
Reviewing files that changed from the base of the PR and between 4b996a996faa40b761ea72c5124e084343802e56 and 44264fe251f8233ec95ec48541910318e130b887.

📝 Walkthrough

## Walkthrough The changes in this pull request involve the restructuring of PostgreSQL configuration parameters within several Bicep files. The existing `postgresSku` parameter has been replaced with a new `postgresConfiguration` parameter, which organizes SKU details into a nested object and introduces a boolean parameter, `enableQueryPerformanceInsight`. This adjustment modifies how PostgreSQL resources are defined and configured across multiple files, while maintaining the overall structure of the Bicep files. ## Changes | File | Change Summary | |-------------------------------------------|------------------------------------------------------------------------------------------------------------------------| | `.azure/infrastructure/main.bicep` | Replaced `postgresSku` with `postgresConfiguration` (object with `sku` and `enableQueryPerformanceInsight`). | | `.azure/infrastructure/prod.bicepparam` | Updated `postgresSku` to `postgresConfiguration` with nested structure (`sku` and `enableQueryPerformanceInsight`). | | `.azure/infrastructure/staging.bicepparam` | Removed `postgresSku`, added `postgresConfiguration` with nested structure (`sku` and `enableQueryPerformanceInsight`). | | `.azure/infrastructure/test.bicepparam` | Updated `postgresSku` to `postgresConfiguration` with nested structure. | | `.azure/infrastructure/yt01.bicepparam` | Updated `postgresSku` to `postgresConfiguration` with nested structure. | | `.azure/modules/postgreSql/create.bicep` | Added `enableQueryPerformanceInsight` parameter to conditionally create new resources based on its value. | ## Possibly related PRs - #1257: Modifies the `postgresSku` parameter in the `.azure/infrastructure/test.bicepparam` file, replacing it with `postgresConfiguration`, directly related to the main PR's changes. - #1290: Updates the `postgresSku` parameter to `postgresConfiguration` in the `.azure/infrastructure/yt01.bicepparam` file, aligning with the main PR's changes to PostgreSQL configuration. ## Suggested reviewers - oskogstad - knuhau

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

🪧 Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.