feat(azure): adjust SKU and storage for yt01 and prod

arealmaas commented 1 day ago

This reverts commit 304f4da7eae3657dc85118bbedce393d1a12d5a8.

Description

The sku and storage now match what Storage has configured their database with in yt01

Related Issue(s)

N/A Disussed here: https://digdir.slack.com/archives/C07R312076E/p1732198146365369

Verification

[ ] Your code builds clean without any errors or warnings
[ ] Manual testing done (required)
[ ] Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

[ ] Documentation is updated (either in docs-directory, Altinnpedia or a separate linked PR in altinn-studio-docs., if applicable)

Summary by CodeRabbit

New Features
- Enhanced PostgreSQL configuration with new storage settings, including size and auto-grow options.
- Updated SKU for PostgreSQL resources to a higher capacity version.
Bug Fixes
- Improved flexibility in the PostgreSQL resource setup by allowing dynamic storage configurations.
Documentation
- Updated parameter definitions to reflect new storage properties and SKU options.

coderabbitai[bot] commented 1 day ago

📝 Walkthrough

## Walkthrough The pull request introduces modifications across several Bicep files to enhance the configuration of PostgreSQL resources. Key changes include the addition of a new `StorageConfiguration` type and updates to the `postgresConfiguration` parameter to include storage properties such as `storageSizeGB`, `autoGrow`, and `type`. The SKU for PostgreSQL resources is also updated to a higher capacity version. These changes allow for more granular control over PostgreSQL storage settings during deployment. ## Changes | File Path | Change Summary | |--------------------------------------------|----------------------------------------------------------------------------------------------------------------------| | `.azure/infrastructure/main.bicep` | Added import for `StorageConfiguration`, updated `postgresConfiguration` to include `storage`, modified module instantiation to pass `storage`. | | `.azure/infrastructure/prod.bicepparam` | Updated `postgresConfiguration` SKU from `Standard_D4ads_v5` to `Standard_D8ads_v5`, added new `storage` object with properties. | | `.azure/infrastructure/staging.bicepparam`| Enhanced `postgresConfiguration` by adding `storage` object with `storageSizeGB`, `autoGrow`, and `type` properties. | | `.azure/infrastructure/test.bicepparam` | Updated `postgresConfiguration` to include `storage` object with `storageSizeGB`, `autoGrow`, and `type` properties. | | `.azure/infrastructure/yt01.bicepparam` | Updated `postgresConfiguration` SKU from `Standard_D4ads_v5` to `Standard_D8ads_v5`, added `storage` object with properties. | | `.azure/modules/postgreSql/create.bicep` | Added `StorageConfiguration` type, updated `sku` type to include `Standard_D8ads_v5`, modified `postgres` resource to use dynamic storage properties. | ## Possibly related PRs - **#1257**: Updates the `postgresConfiguration` parameter in the `.azure/infrastructure/test.bicepparam` file to include a new `storage` object. - **#1290**: Modifies the `.azure/infrastructure/yt01.bicepparam` file to include a new `storage` object in the `postgresConfiguration` parameter. - **#1417**: Introduces a new `postgresConfiguration` parameter structure that includes `enableQueryPerformanceInsight`. - **#1448**: Ensures that PostgreSQL configuration resources are created in sequence. - **#1450**: Updates the `postgresConfiguration` parameter's SKU name in the `.azure/infrastructure/prod.bicepparam` and `.azure/infrastructure/yt01.bicepparam` files. - **#1455**: Adds a new parameter `enableIndexTuning` to the `postgresConfiguration` structure. ## Suggested reviewers - oskogstad

[!WARNING]

Rate limit exceeded

@arealmaas has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 12 minutes and 9 seconds before requesting another review.

⌛ How to resolve this issue?
After the wait time has elapsed, a review can be triggered using the `@coderabbitai review` command as a PR comment. Alternatively, push new commits to this PR. We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?
CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our [FAQ](https://docs.coderabbit.ai/faq) for further information.

📥 Commits
Reviewing files that changed from the base of the PR and between aed173a7f43648aa3e035b25c3105199fb41f6ed and e3e8bb2fe8b56dae4c186cffb854c90f7ff30302.

📜 Recent review details

**Configuration used: .coderabbit.yaml** **Review profile: CHILL**

📥 Commits

Reviewing files that changed from the base of the PR and between aed173a7f43648aa3e035b25c3105199fb41f6ed and e3e8bb2fe8b56dae4c186cffb854c90f7ff30302.

📒 Files selected for processing (1)

* `.azure/modules/postgreSql/create.bicep` (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

* .azure/modules/postgreSql/create.bicep

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

🪧 Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### Documentation and Community - Visit our [Documentation](https://docs.coderabbit.ai) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.