fix(azure): ensure correct properties are used when adjusting SKU and storage for postgres

arealmaas commented 11 hours ago

Description

By setting 256gb as storage size, the IOPS will be p15

Related Issue(s)

{issue number}

Verification

[ ] Your code builds clean without any errors or warnings
[ ] Manual testing done (required)
[ ] Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

[ ] Documentation is updated (either in docs-directory, Altinnpedia or a separate linked PR in altinn-studio-docs., if applicable)

Summary by CodeRabbit

New Features
- Simplified PostgreSQL storage configuration by removing the tier specification, streamlining the setup process.
Bug Fixes
- Addressed inconsistencies in the PostgreSQL resource definitions related to storage tier configurations.

coderabbitai[bot] commented 11 hours ago

📝 Walkthrough

## Walkthrough The pull request includes changes to several Bicep files related to Azure infrastructure, specifically focusing on the `postgresConfiguration` parameter. The modifications involve the removal of the `tier` property from the `storage` object in both `.bicepparam` files and the `create.bicep` file for PostgreSQL resources. This simplification affects how PostgreSQL storage is configured, while other parameters and structures remain unchanged. ## Changes | File | Change Summary | |-------------------------------------------|---------------------------------------------------------------------------------------------------------| | `.azure/infrastructure/prod.bicepparam` | Updated `postgresConfiguration`: removed `tier` property from `storage` object. | | `.azure/infrastructure/yt01.bicepparam` | Updated `postgresConfiguration`: removed `tier` property from `storage` object. | | `.azure/modules/postgreSql/create.bicep` | Updated `StorageConfiguration`: removed `tier` property from type definition and resource definition. | ## Possibly related PRs - **#1257**: Modifies the `postgresSku` parameter in the `.azure/infrastructure/test.bicepparam` file, directly related to changes in `postgresConfiguration`. - **#1290**: Updates `postgresConfiguration` in the `.azure/infrastructure/yt01.bicepparam` file in a similar manner as the main PR. - **#1417**: Introduces a new parameter `enableQueryPerformanceInsight` to `postgresConfiguration`, related to the main PR changes. - **#1448**: Ensures PostgreSQL configuration runs in sequence, relevant to modifications in `postgresConfiguration`. - **#1450**: Updates the `postgresConfiguration` parameter's SKU name, directly related to changes in the main PR. - **#1455**: Adds a new parameter `enableIndexTuning` to `postgresConfiguration`, relevant to the main PR changes. - **#1508**: Adjusts SKU and storage configurations for PostgreSQL, aligning with changes made in the main PR. ## Suggested reviewers - oskogstad - knuhau

📜 Recent review details

**Configuration used: .coderabbit.yaml** **Review profile: CHILL**

📥 Commits

Reviewing files that changed from the base of the PR and between a87b3e18553ff713faf651a32a3ca30fba9e285d and 29732542eb07f89d4e1982412443fcbded5ff9fe.

📒 Files selected for processing (3)

* `.azure/infrastructure/prod.bicepparam` (0 hunks) * `.azure/infrastructure/yt01.bicepparam` (0 hunks) * `.azure/modules/postgreSql/create.bicep` (0 hunks)

💤 Files with no reviewable changes (3)

* .azure/infrastructure/prod.bicepparam * .azure/infrastructure/yt01.bicepparam * .azure/modules/postgreSql/create.bicep

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

🪧 Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### Documentation and Community - Visit our [Documentation](https://docs.coderabbit.ai) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.