search

digdir / dialogporten

Dialogporten - common API and and metadata state store for digital dialogs
https://docs.altinn.studio/dialogporten
MIT License
1 stars 3 forks source link

feat: Implement scalable dialog search authorization #875

Closed elsand closed 3 weeks ago

elsand commented 3 months ago

Description

This implements a authorized-parties based approach to list/search authorization, which should scale better than the current approach.

This builds on the syncronization of data from RR, which contains a map of subjects (role codes and eventually access packages) and resources. This data is persisted in Dialogporten DB, and used as a cache.

A new predicate builder PrefilterAuthorizedDialogs replacesWhereUserIsAuthorizedFor, and constructs a SQL manually in order to propertly handle the new property SubjectsByParties in DialogSearchAuthorizationResult, which is a dict of party->subjects. Each of the roles grant access to a list of resources.

This also removes legacy system users, as they cannot be authorized this way (not possible to get a list of parties from Authorization APIs for a legacy system user).

Related Issue(s)

Verification

Documentation

Summary by CodeRabbit

sonarcloud[bot] commented 3 weeks ago

Quality Gate Passed Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

elsand commented 2 weeks ago

@coderabbitai full review

coderabbitai[bot] commented 2 weeks ago
Actions performed Full review triggered.
coderabbitai[bot] commented 2 weeks ago

[!CAUTION]

Review failed

The pull request is closed.

Walkthrough ## Walkthrough Dis big change, it involves removin' old support for Altinn 2 enterprise users and addin' new methods for handlin' party identifiers. Many legacy methods gone, and new ones introduced to make user type handling better. Also, some classes got new methods for filterin' and authorization. Overall, it’s a big shift toward modern user management and authorization processes. ## Changes | File Path | Change Summary | |---------------------------------------------------------------------------|-------------------------------------------------------------------------------------------------------------------| | `src/.../ClaimsPrincipalExtensions.cs` | Removed legacy user methods; added new methods for party identifiers. | | `src/.../DbSetExtensions.cs` | Added `PrefilterAuthorizedDialogs` method for filtering dialogs based on authorization. | | `src/.../QueryableExtensions.cs` | Removed `WhereUserIsAuthorizedFor` method, simplifying authorization logic. | | `src/.../IUserParties.cs` | Updated `GetUserParties` to include a named argument for `cancellationToken`. | | `src/.../IUserRegistry.cs` | Refined user identification handling; simplified `GetCurrentUserInformation` method. | | `src/.../Pagination/PaginatedList.cs` | Added methods for transforming items and creating empty paginated lists. | | `src/.../AltinnAuthorization/AuthorizedPartiesResult.cs` | Changed `AuthorizedParties` property to mutable; added new properties for roles and parent party. | | `src/.../AltinnAuthorization/DialogSearchAuthorizationResult.cs` | Replaced `PartiesByResources` with `SubjectsByParties`, updating authorization checks. | | `src/.../AltinnAuthorization/IAltinnAuthorization.cs` | Modified `GetAuthorizedParties` method to include an optional `flatten` parameter. | | `src/.../Features/V1/EndUser/Dialogs/Queries/Search/SearchDialogQuery.cs` | Improved authorization checks and pagination handling in dialog search. | | `src/.../Domain/Dialogs/Entities/DialogUserType.cs` | Removed `LegacySystemUser` type and renumbered remaining user types. | | `src/.../Infrastructure/Altinn/Authorization/AltinnAuthorizationClient.cs` | Updated authorization requests and removed dependency on `IDialogDbContext`. | | `src/.../Infrastructure/Altinn/Authorization/DecisionRequestHelper.cs` | Removed `NonScalable` class, indicating a shift to a more robust solution. | | `src/.../Infrastructure/Persistence/DevelopmentSubjectResourceSyncHostedService.cs` | Added a hosted service for synchronizing subject resource mappings. | | `src/.../WebApi/Properties/launchSettings.json` | Added environment variables for logging configuration using Serilog. | | `src/.../GenerateFakeData/DialogGenerator.cs` | Enhanced fake data generation with optional generator functions. | | `src/.../Benchmarks/QueryableExtensionsBenchmark.cs` | Removed benchmark tests for the deleted `WhereUserIsAuthorizedFor` method. | | `tests/.../QueryableExtensionsTests.cs` | Deleted tests for the removed `WhereUserIsAuthorizedFor` method. | ## Possibly related PRs - **#1110**: This PR removes legacy user support and introduces new user identifier methods, similar to the focus on enhancing user interaction in this PR.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: -- `I pushed a fix in commit , please review it.` -- `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: -- `@coderabbitai generate unit testing code for this file.` -- `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: -- `@coderabbitai generate interesting stats about this repository and render them as a table.` -- `@coderabbitai read src/utils.ts and generate unit testing code.` -- `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` -- `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.