search

digego / extempore

A cyber-physical programming environment
1.41k stars 127 forks source link

Proposal: Assign '(0 2 4 5 7 9 11) to variables #337

Closed cyblue9 closed 4 years ago

cyblue9 commented 6 years ago

I am learning extempore in the docs.

A lot of '(0 2 4 5 7 9 11) comes out in the chapter of Note-level music.

Therefore, I think that it would be better to assign '(0 2 4 5 7 9 11) to variables.

Example:(libs/core/pc_ivl.xtm)

(define *pc:natural-note*
   '(0 2 4 5 7 9 11))

What do you think?

benswift commented 6 years ago

Well, that's just the pitch classes for the C major ionian mode, and is already represented more generally as an interval list in the *pc:scales* variable.

So I don't think it's appropriate to put the hardcoded C-major version in the lib - the lib should be "key-agnostic" wherever possible.

However, perhaps we could better explain that list of magic numbers? What do you think?

cyblue9 commented 6 years ago

Oh, I see! I understood that by reading to the source code of pc:scale function. Thank you for explain😁!!!

Yes, I agree to explain *pc:scales* variable in the chapter of Note-level music of docs!