Add some scales - Githubissues

cyblue9 commented 5 years ago

Hi!

I added some scales.

REF:List of musical scales and modes

Question Above page explains major pentatonic scale and minor pentatonic scale. So, I want to add minor pentatonic scale. Therefore, May I change Existing pentatonic variable to ^pentatonic variable? (and I am going to add -pentatonic variable.)

Please review!

benswift commented 5 years ago

Fine with me, but I'll just check with @digego re: naming conventions - do you want them, and what do you want them to be called?

digego commented 5 years ago

Hi, thanks for updates!

I think that we should maintain the 'major pentatonic' as simply 'pentatonic' and then add the minor pentatonic as 'pentatonic-minor'. I don't really think of pentatonic as both major and minor. I think of it as simply pentatonic, and some people like to 'construct' a minor variant.

I'm also unsure about what ^melodic and -melodic are supposed to be? Melodic minor I'm guessing, but I'm unsure how these are supposed to translate, and how useful they are? Don't we just want (melodic . (2 1 2 2 2 2))? The 'downward' trajectory is simply aeolian?

just my 2cents

cyblue9 commented 5 years ago

Thanks to reply!

I think that we should maintain the 'major pentatonic' as simply 'pentatonic' and then add the minor pentatonic as 'pentatonic-minor'. I don't really think of pentatonic as both major and minor. I think of it as simply pentatonic, and some people like to 'construct' a minor variant.

Since no other scale minor variants are defined, it may not be necessary to define a pentatonic minor variant as well. I cancel defining pentatonic minor variant.

I'm also unsure about what ^melodic and -melodic are supposed to be? Melodic minor I'm guessing, but I'm unsure how these are supposed to translate, and how useful they are? Don't we just want (melodic . (2 1 2 2 2 2))? The 'downward' trajectory is simply aeolian?

Oh, I see. I did not understand the melody scale well. You are right. I will fix to define (melody (2 1 2 2 2 2)) only.

cyblue9 commented 5 years ago

Fixed it.

Please Re-review!

cyblue9 commented 5 years ago

Ping... @digego

cyblue9 commented 5 years ago

Thank you very much! 😀

digego / extempore

Add some scales #348