search

digero / maestro

Maestro and ABC Player for The Lord of the Rings Online
MIT License
58 stars 17 forks source link

Key change #3

Open ghost opened 8 years ago

ghost commented 8 years ago

When opening an abc file for editing in Maestro and then subsequently saving the file, the key is changed to C Maj. I don't know if this is intended but I have ruined hundreds of files because of this!

Is it possible to retain the original key and preserve the original music while still retaining the ability to edit the text fiels in the file?

digero commented 6 years ago

This is something that would be nice to implement, but it is not a simple feature to add. The key in the .abc file doesn't affect playback in LOTRO, which makes this a relatively low priority given Maestro's primary purpose is to make .abc files for LOTRO. Maestro adds in the appropriate sharps to make the same notes as the original key, even though the exported key is C Maj.

ghost commented 6 years ago

Thanks for the explanation.

Keep up the good work, I have a feeling SSG have a taste for new instruments now!

On 26 April 2018 at 20:38, digero notifications@github.com wrote:

This is something that would be nice to implement, but it is not a simple feature to add. The key in the .abc file doesn't affect playback in LOTRO, which makes this a relatively low priority given Maestro's primary purpose is to make .abc files for LOTRO. Maestro adds in the appropriate sharps to make the same notes as the original key, even though the exported key is C Maj.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/digero/maestro/issues/3#issuecomment-384764820, or mute the thread https://github.com/notifications/unsubscribe-auth/APeXwwWplkxONd2zLiWb9fSJ9iRlgdeRks5tsiIjgaJpZM4Gx6ga .