search

digero / maestro

Maestro and ABC Player for The Lord of the Rings Online
MIT License
58 stars 17 forks source link

Problems #8

Closed Az-rhad closed 5 years ago

Az-rhad commented 6 years ago

Hello, No possibilities to save the new fiddles .... No name changement, nor sound ! I had to downgrade to Nikolai Releases :( Can you take a look ?

Needabrew commented 6 years ago

Yes I have the same problem. Saving as .msx has the changes to the new insts in it, but exporting to ABC keeps the old value. I edited an existing abc file changing an instrument to new fiddle.

digero commented 6 years ago

I'm having trouble reproducing this or understanding exactly what the bug is. Could you list step-by-step instructions for reproducing it? (be as specific as possible)

It would help if you attach .mid, .msx, and .abc files that have the problem, too.

For example:

1. Open the attached midi file in Maestro 2. Add a Traveller's Trusty Fiddle part and add track 2 to it 3. Export to ABC 4. Open the ABC file in ABC Player, and it uses Basic Lute when it should use Traveller's Trusty Fiddle.

Thanks!

Needabrew commented 6 years ago

More info on this. If you change the instrument in the pull-down list, you HAVE to manually type in the exact name as the pull down in the Part name box, or after exporting, it will play the first instrument that matches the Part name rather than the instrument in the pull-down list. Sent you files. I do believe this to be in error, as it should be picking up the instrument from the pull-down, not the part name.

And thank you!

Az-rhad commented 6 years ago

Excuse my english, i'm French ... Like Needabrew say, you have to change the part name. For example : Opening a ABC File image Changing the fiddle by an other fiddle : image Nothing happen. And if save, nothing happen but the new fiddle disappear : image But if i change part name and put the exact instrument : image and i save image It is good ! I hope that this can help you.

Az-rhad commented 6 years ago

In fact, I'm think the problem is only when you have a "Student Fiddle No FX" as an instrument ! No problem to change other instruments to fiddle ! Only when No Fx is before selectionned.

Needabrew commented 6 years ago

Any update on this bug? Have you been able to reproduce it?

Thanks!

digero commented 5 years ago

I think this should be fixed in v2.5.0. Let me know if it's still not working as you expect. You can download it here: https://github.com/digero/maestro/releases

Hannariel commented 5 years ago

Oh, my gosh! Thank you so much!

Our band has been patiently waiting for this. We so appreciate the work you do for the music community in lotro, even though you aren't actively playing any more.

Hannariel, Fluffy Unicorn bandleader

From: "digero" notifications@github.com To: "digero/maestro" maestro@noreply.github.com Cc: "Subscribed" subscribed@noreply.github.com Sent: Monday, November 12, 2018 1:07:29 AM Subject: Re: [digero/maestro] Problems (#8)

I think this should be fixed in v2.5.0. Let me know if it's still not working as you expect. You can download it here: https://github.com/digero/maestro/releases

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub , or mute the thread .