search

diggerhq / digger

Digger is an open source IaC orchestration tool. Digger allows you to run IaC in your existing CI pipeline ⚡️
https://digger.dev
Apache License 2.0
3.47k stars 176 forks source link

Remove isNonEmptyPlan from the Plan() method of the Executor interface #1029

Open ZIJ opened 9 months ago

ZIJ commented 9 months ago

We no longer use it; in #1028 we switched to parsing actual plan output json to determine whether or not it's empty So the is confusing

type Executor interface {
    Plan() (bool, bool, string, string, error)
    Apply() (bool, string, error)
    Destroy() (bool, error)
}
Jyoti050402 commented 9 months ago

Hey @ZIJ I want to work on this issue. Can you please assign me?

ty-labs commented 4 months ago

Should this issue be removed? Seems like it is stale as isNonEmptyPlan looks like it is used now: https://github.com/diggerhq/digger/blob/1d592f932ed9b3edfaeb458ed2d8bb8f1d423b7a/cli/pkg/digger/digger.go#L268-L281