jonasseglare
commented
2 years ago The following unittest reproduces the issue with en¤ appearing in the output:
@Test
void testEmptyString() throws Exception {
String jsonSource = "{\"about\":\"Mjao\",\"info\":{\"description\":\"Annotation exempel api är ett påhittat api som använder sig av annotations för att skapa metadata för DCAT-AP-SE.\",\"title\":\"Annotation exempel api\",\"version\":\"1.0.0\",\"x-dcat\":{\"dcat-catalog\":{\"about\":\"http://www.af.se\",\"description-sv\":\"Arbetsförmedlingen med flera api'er\",\"homepage\":\"www.arbetsformedlingen.se\",\"issued\":\"2021-04-01\",\"license\":\"http://www.apache.org/licenses/LICENSE-2.0\",\"modified\":\"2021-04-02\",\"publisher\":{\"about\":\"http://www.example.se/result.rdf#publisher\",\"homepage\":\"www.publishertest.se\",\"mbox\":\"publisher1@publisher.com\",\"name\":\"Arbetsförmedlingens Catalog\",\"type\":\"Company\"},\"rights\":{\"attributionText-sv\":\"Detta är ett exempel på rättighetstext för Catalog\",\"attributionURL\":\"www.rattighetstextcatalog.se\",\"copyrightHolder\":{\"about\":\"www.exempel.se/#copyrightHolderCatalog\",\"homepage\":\"www.holder.com\",\"name\":\"Copyright Holder för Catalog\",\"type\":\"RegionalAuthority\"},\"copyrightNotice\":\"Upphovsrätt\",\"copyrightStatement\":{\"about\":\"https://www.example.se/#catalog/statement\",\"description-sv\":\"license för Catalog\",\"title-sv\":\"License För Catalog\"},\"copyrightYear\":\"1979\",\"jurisdiction\":\"www.nywebaddresscat.com\",\"reuserGuidelines\":\"www.guidelinescat.se\"},\"title-en\":\"Example of a catalog for an organistaion with several api's\",\"title-sv\":\"Exempel på catalog för en organisation med flera api'n\"},\"dcat-dataset\":{\"about\":\"https://data.jobtechdev.se/taxonomy/chefsyrken.jsonabout0\",\"accessRights\":\"Public\",\"accrualPeriodicity\":\"http://publications.europa.eu/resource/authority/frequency/UNKNOWN\",\"contactPoint\":{\"about\":\"https://www.example.se/#contactYrkesbenämningar\",\"address\":\"Elektrogatan 4; 171 54; Solna; Sverige\",\"email\":\"jobtechdev@arbetsformedlingen.se\",\"name\":\"Arbetsförmedlingen\",\"type\":\"Organization\"},\"description-en\":\"No description\",\"description-sv\":\"Beskrivning saknas\",\"distribution\":{\"about\":\"https://data.jobtechdev.se/taxonomy/chefsyrken.json#about1\",\"accessURL\":\"https://data.jobtechdev.se/taxonomy/chefsyrken.json\",\"availability\":\"Stable\",\"description-en\":\"No description\",\"description-sv\":\"Beskrivning saknas\",\"downloadURL\":\"https://data.jobtechdev.se/taxonomy/chefsyrken.json\",\"formatMedia\":\"application/json\",\"licenseurl\":\"http://creativecommons.org/publicdomain/zero/1.0/\",\"status\":\"Completed\",\"title\":\"\",\"title-en\":\"\",\"title-sv\":\"Chefsyrken\"},\"keyword-en\":\"Ocupation,\",\"keyword-sv\":\"Taxonomi, Jobtech, Arbetsförmedlingen\",\"landingPage\":\"atlas.jobtechdev.se\",\"licenseurl\":\"http://creativecommons.org/publicdomain/zero/1.0/\",\"spatialUrl\":\"https://www.geonames.org/6695072/european-union.html\",\"theme\":\"GOVE\",\"title\":\"\",\"title-en\":\"\",\"title-sv\":\"Chefsyrken\"}}},\"openapi\":\"3.0.3\",\"paths\":{\"/users\":{\"get\":{\"description\":\"Fake API description. Only in this file to show where the rest of the api definition would be located.\",\"responses\":{\"200\":{\"description\":\"Fake 200 response\"}}}}}}";
Manager mgr = new Manager();
File jsonSourceFile = File.createTempFile("dcat_with_missing_value_test", ".json");
Path path = jsonSourceFile.toPath();
ArrayListValuedHashMap<String, String> apiSpecMap = new ArrayListValuedHashMap<String, String>();
apiSpecMap.put(path.toString(), jsonSource);
String result = manager.createDcat(apiSpecMap);
assertTrue(result.startsWith("<rdf:RDF"));
assertFalse(result.contains("en¤"));
}
jonassodergren
If an empty string is provided as an attribute, the output generates an attribute like "en¤". This propagates to be visible in "dataportalen". I interpret "en¤" to be a "empty string in the english language"
The behaviour is confusing. Expected behaviour is one of:
/Joakim