search

diggsweden / dgc-java

Java implementation of the EU eHealth Digital Green Certificates.
MIT License
27 stars 25 forks source link

Test testSimpleCreate in DefaultBarcodeCreatorTest fails on any computer running a system characterset other than "Latin I" #52

Closed jozemlakar closed 3 years ago

jozemlakar commented 3 years ago

Test testSimpleCreate in DefaultBarcodeCreatorTest fails on any computer running a system characterset other than "Latin I". This is due to combination of character Ö being available in simple charset of "Latin I" but not being available in other simple charsets.

I tried using UTF-8 encoding both in literal values as well as in building the QR code, but was unsuccessful.

martin-lindstrom commented 3 years ago

But the Java files should all be in UTF-8. Could you elaborate?

jozemlakar commented 3 years ago

Maybe. Probablly. The fact is that the test fails. And the fact is that the test generates QR code with the string while using encoding "null", meaning default. I aslo tried to change the value to proper UTF-8 and set the encoding for the string to byte conversion but no love.

Regardless, we forked the repo, changed the value so we don't have a problem. Just thought others might benefit from this fix.

martin-lindstrom commented 3 years ago

I have written a stupid testcase anyway. In all practical cases a Base45 encoded string will be used, and that string is pure ASCII. But I'll look into it anyway.