search

diggsweden / jitsi-outlook

A Jitsi plugin for outlook.
MIT License
5 stars 7 forks source link

Generated meeting room name contains == which breaks pin code generation #10

Closed small1 closed 1 year ago

small1 commented 1 year ago

Contact Details

johan.bernhardsson@redpill-linpro.com

What happened?

The generated room name with window.btoa() will break pin code generation. When you fetch a pin code for a meeting it will be requested with roomname@server my own api and the main jitsi generator strips off = signs and thus the meeting will be given a completely different pin in the meeting than whats in the invite.

Fix would be just to use a longer random string. Since the string generated is complicated enought we dont need to base64 encode

Steps To Reproduce

My feature for dial in will be added later.

What did you expect?

get the correct pin code

Version

No response

Optional Screenshots

No response

Relevant log output

No response

small1 commented 1 year ago

This was already fixed ..... note to self. Read the code first! :)