Invalid locales in Manifest file

[Ayko1595]

Contact Details

konstantin.ay@intunio.se

What happened?

A prior feature introduced invalid language locales into the manifest file. These have now made the manifest file invalid.

Steps To Reproduce

Run the following command in the root of the project:

npm run validate

This will generate the following error:

Error #1:
XML Schema Validation Error: Error found during XML Schema validation.
  - Details: The 'Locale' attribute is invalid - The value 'sv_SE' is invalid according to its datatype 'http://schemas.microsoft.com/office/officeappbasictypes/1.0:CultureName' - The Pattern constraint failed.
  - Line: 83
  - Column: 26

Error #2:
XML Schema Validation Error: Error found during XML Schema validation.
  - Details: The 'Locale' attribute is invalid - The value 'de_DE' is invalid according to its datatype 'http://schemas.microsoft.com/office/officeappbasictypes/1.0:CultureName' - The Pattern constraint failed.
  - Line: 84
  - Column: 26

Error #3:
XML Schema Validation Error: Error found during XML Schema validation.
  - Details: The 'Locale' attribute is invalid - The value 'sv_SE' is invalid according to its datatype 'http://schemas.microsoft.com/office/officeappbasictypes/1.0:CultureName' - The Pattern constraint failed.
  - Line: 87
  - Column: 26

Error #4:
XML Schema Validation Error: Error found during XML Schema validation.
  - Details: The 'Locale' attribute is invalid - The value 'de_DE' is invalid according to its datatype 'http://schemas.microsoft.com/office/officeappbasictypes/1.0:CultureName' - The Pattern constraint failed.
  - Line: 88
  - Column: 26

Error #5:
XML Schema Validation Error: Error found during XML Schema validation.
  - Details: The 'Locale' attribute is invalid - The value 'sv_SE' is invalid according to its datatype 'http://schemas.microsoft.com/office/officeappbasictypes/1.0:CultureName' - The Pattern constraint failed.
  - Line: 93
  - Column: 26

Error #6:
XML Schema Validation Error: Error found during XML Schema validation.
  - Details: The 'Locale' attribute is invalid - The value 'de_DE' is invalid according to its datatype 'http://schemas.microsoft.com/office/officeappbasictypes/1.0:CultureName' - The Pattern constraint failed.
  - Line: 94
  - Column: 26

Error #7:
XML Schema Violation: Your manifest does not adhere to the current set of XML schema definitions for Office Add-in manifests.

What did you expect?

The Manifest file should be valid.

Version

No response

Optional Screenshots

No response

Relevant log output

No response

[small1]

This is really strange. Because those locales are the ones that actually gives the right language after manual tests. But after reading up it perhaps shoud be sv-SE

https://learn.microsoft.com/en-us/dotnet/api/system.globalization.cultureinfo?view=net-6.0#cultureinfo-and-cultural-data

https://community.inriver.com/hc/en-us/community/posts/360010064099-List-of-country-codes-Windows-Language-Culture-Names

[Ayko1595]

Yes I also thought it was quite strange, but I'm on it and will be making a PR later today! :-)

[Ayko1595]

PR is available https://github.com/diggsweden/jitsi-outlook/pull/25