diggsweden / jitsi-outlook

A Jitsi plugin for outlook.
MIT License
5 stars 7 forks source link

Add JWT support #29

Closed fredriksundin closed 1 year ago

fredriksundin commented 1 year ago

Add JWT support

Description

This will add support for JWT authentication by adding the following config options: jwt?: { iss: string; key: string; exp?: number; }

Checklist

Ayko1595 commented 1 year ago

Thank you for your Pull Request in this repository! We always encourage contributions. However, according to our CONTRIBUTING guide, new features should be suggested as an issue first, and then their relevancy, and use case should be discussed.

The intention of the plugin is to create a URL for a future meeting, which makes it challenging to derive the expiration time of the JWT token consistently. We could potentially ignore the exp claim, but the expiration time is a recommended claim by the JWT RFC, and having immortal tokens in everyone’s mail inboxes is not secure. Additionally, this approach would assume that the system consuming the token ignores its expiry.

Therefore, we will unfortunately not be able to merge this Pull Request.