diggsweden / jitsi-outlook

A Jitsi plugin for outlook.
MIT License
5 stars 7 forks source link

Added subject to meeting link, this will show up in tab #46

Closed Philldomd closed 1 month ago

Philldomd commented 1 month ago

Pull Request Description

I have added a call to the subject row of the composed meeting. The commit handles empty subject, character removal and cleaning of the subject row. It will automatically remove åäö ÅÄÖ or any other special characters not used in URI and replace with the URI alternative, i.e Ö becomes O and Å becomes A and so on. Link will look something like this: Mote-angaende-nasta-sprint if the original was Möte angående nästa sprint. Random string will be added at the end to eliminate collisions.

Fixes #45

Checklist

Ayko1595 commented 1 month ago

Thanks for your contribution! Similar to PR #47 – This PR is missing signed off commits, could you fix that as a commit amend. The meeting link got an underscore "_" as a prefix before the meeting id when the subject field was left empty. Was this intentional? Besides from that the code looks good, and great work on the tests!

Philldomd commented 1 month ago

All commits are signed with my gpg. That underscore should not be in this commit. It is for the next development stage where I introduce multi tenant. It will then fetch company prefix from config and then add meeting. Like co_subject_meetingid