diggsweden / open-source-project-template

Open Source project helper and getting started template(s)
Creative Commons Zero v1.0 Universal
18 stars 4 forks source link

docs: update standard for public code assessment #16

Closed Ainali closed 1 year ago

Ainali commented 1 year ago

Description

This contains the assessment as performed by Jan Ainali and Eric Herman towards the Standard for Public Code version 0.7.1 as of the previous commit.

Checklist

janderssonse commented 1 year ago

Thanks, @Ainali I think you will have github know about your gmail pub key (so that you are a verified user)

Ainali commented 1 year ago

Thanks, @Ainali I think you will have github know about your gmail pub key (so that you are a verified user)

Oh, thanks for the reminder, I should fix that. Is this a blocker for the contribution? If so, perhaps clarify that in the CONTRIBUTING file, as it seemed to be optional when I read it.

janderssonse commented 1 year ago

Thanks will do. You are most likely correct, it was optional in the text, but as a must in the linters so there is currently a mismatch.

janderssonse commented 1 year ago

Merged in https://github.com/diggsweden/open-source-project-template/commit/f5be1a5988b10d09d0360247f23a9c5d606556c8. We'll fix the contributor thingie before next round.

janderssonse commented 1 year ago

So closing this thanks!