diggyk / fildir

VSCode extension: Filtered Directories
GNU General Public License v3.0
6 stars 0 forks source link

Add ability to filter files #2

Closed akulmehta closed 1 year ago

akulmehta commented 1 year ago

Currently fildir only filters folders. However, some folders are sometimes with many files. It would be great if fildir can filter files also. Maybe this can be enabled in some settings?

Really useful extension by the way - thanks.

diggyk commented 1 year ago

I'll look into it. I think it should be doable. Glad you like the extension!

diggyk commented 1 year ago

@akulmehta check out the pre-release version and see if that works for you. I need to add actual unit tests but I hand verified.

akulmehta commented 1 year ago

@diggyk just tried it. It is not showing in the Filtered View. I think this is because the FilDir is adding a trailing / to the filename. Files should not have a trailing /

image

diggyk commented 1 year ago

Hmm. I thought I removed code to add the trailing slashes. Let me push a fix tonight (traveling at the moment)

diggyk commented 1 year ago

Is that file a symlink by any chance? I can't repro this with the pre-release version of the extension. I only add a trailing / when the filetype is directory.

akulmehta commented 1 year ago

I am not sure what you mean by symlink - it is just a regular file.

diggyk commented 1 year ago

Strange. The other thing that may have happened is it added the trailing slash when refreshing and normalizing the configs before it switched to the pre-release version. I can't repro this. When I right click a file and create a new filter, it doesn't add the slash if it was a file as opposed to a directory. I'll keep trying.

akulmehta commented 1 year ago

I just disabled the extension, enabled it again and then switched to pre-release and reloaded and now everything works including issue #3

akulmehta commented 1 year ago

@diggyk - since it is working now could you put the changes in the release version?

diggyk commented 1 year ago

Done! I'm working on getting Intellisense to work, if possible.