Various Fixes / Changes to our kitchen sink tests

digi-serve / kitchensink_app

Testing all AppBuilder options.

1 stars 1 forks source link

Various Fixes / Changes to our kitchen sink tests #97

Closed Hiro-Nakamura closed 7 months ago

Hiro-Nakamura commented 7 months ago

Some of these update our tests because our tests are outdated, and some of these changes work better on a system that is older and slower. Hopefully those changes don't invalidate the tests, just make sure they wait longer for a slower system to respond.

Release Notes

[fix] widget_carousel has more icon buttons now
[wip] increase timeout on finding menu button for slower test systems (mine)
[fix] remove usermulti from combine field.

nh758 commented 7 months ago

Note: [wip] remove references to Common.RunSql() (https://github.com/digi-serve/kitchensink_app/pull/97/commits/4aacabc53da3488ed66cf21ad4922ea7be6ad700) causes multiple test to fail:

Common.RunSql() will fail silently, so a lot of our tests are written around SQL with errors. When we switched to cy.RunSql(), I wanted these to fail in a way we see and fix them. I hoped that we would slowly switch over to cy.RunSql() and fix the SQL errors. That's why I didn't tackle switching everything over at once, but it has been awhile now.

So: we'll need to fix the underlying SQL errors or keep using Common.RunSql.

Hiro-Nakamura commented 7 months ago

Yeah, apparently our chart and comment tests were manually trying to reapply an sql patch that is already being applied in our integration.cy.js -> beforeAll() case.

Just removing the additional calls in those files will do the trick.

Hiro-Nakamura commented 7 months ago

FYI: I made some updates to allow for a "local" version of the tests to be run that don't perform a complete DB reset before every it("test") is run.

Without these changes, it could take my local system 45 min to run the tests. Which isn't a workable expectation.

With these changes, the integration_local version will run in about 10 min on my system. Much more workable. And only performs the DB resets at specific times when the tests require them.