search

digicademy / svsal

The School of Salamanca. Web Application
MIT License
16 stars 7 forks source link

[oxygen plugin] Fix gap annotation #36

Open dvglc opened 5 years ago

dvglc commented 5 years ago

When annotating gaps ("Fehlstelle"), the plugin currently produces something à la <damage agent="ink"><gap reason="damage" resp="#DG"/></damage>, which is not valid according to our schema due to the lack of @cert. Should rather look like: <damage agent="ink"><gap reason="damage" resp="#DG" cert="high"/></damage>, for example, if the editor is sure that something is missing.

We could always add a default value (high), but I think explicitly asking the editor would be better in such (rather rare) cases.

dvglc commented 4 years ago

After the update to 0.9.22, tei:gap still seems to lack @cert. I have tested this with 2 different oxygen installations and the annotation always produced the same (erroneous) outcome...

awagner-mainz commented 4 years ago

Am I looking at the right command? In "Editorische Eingriffe" | "gap (Fehlstelle)"? Clicking on it and accepting the defaults twice ("ink" damage and "high" certainty) gives the following code:

<damage agent="ink"><gap reason="damage" resp="#AW" cert="high"/></damage>

capture_001_29112019_135214 capture_002_29112019_135306 capture_003_29112019_135341

Is that even correct? If it is, then we should find out why it's working here and not on your computers...

(Can you check if you have set the $svsal-user custom Editor variable (in "Preferences" | "Custom Editor Variables", see screenshot), and if not, if setting it changes anything in the outcome of this command? capture_004_29112019_135920

dvglc commented 4 years ago

I have checked this again in two different oXygen installations, making sure that the editor variable was set (it was reset to "#AW" by the last update, so we changed it to the correct values) and that I pick the right command, and it still doesn't work.

The dialogue always shows only 1 window, the one asking for the gap's reason, but not the other asking for certainty. And the gap element is still lacking @cert.

So, I think we need to find out why it is working in one installation but not in others.

(Btw, has the plugin's update been committed to the master/develop branch already?)