(This diff looks large, but it's just one line of source code and a bunch of tests.)
We have some code like this:
if (isAssigningProjectCreatorRole && !this.#isProjectCreator()) {
The intent: only allow the project creator to change their own role.
However, this.#isProjectCreator returned a Promise, which meant that the second part of the condition always evaluated to false, which meant that the whole condition always evaluated to false, which meant that non-creators could change the creator's role.
This fixes that by making #isProjectCreator return a boolean, not Promise<boolean>.
(This diff looks large, but it's just one line of source code and a bunch of tests.)
We have some code like this:
The intent: only allow the project creator to change their own role.
However,
this.#isProjectCreatorreturned aPromise, which meant that the second part of the condition always evaluated tofalse, which meant that the whole condition always evaluated to false, which meant that non-creators could change the creator's role.This fixes that by making
#isProjectCreatorreturn aboolean, notPromise<boolean>.Found this while working on #188.