search

digidem / comapeo-mobile

The next version of Mapeo mobile
GNU General Public License v3.0
5 stars 1 forks source link

feat: observation photo thumbnail opens modal #383

Closed CDFN closed 4 months ago

CDFN commented 4 months ago

This PR is adding photo preview which is opened when you click a photo thumbnail. This PR closes #229 as there's no more work to do.

Closes #229

CDFN commented 4 months ago

For point 2. - this is covered in follow up pr #385. This PR just adds the modal, so #229 can be closed. I'll address the rest tomorrow, thanks!

ErikSin commented 4 months ago

For point 2. - this is covered in follow up pr #385. This PR just adds the modal, so #229 can be closed. I'll address the rest tomorrow, thanks!

Great. So then the main thing is the flickering UI

CDFN commented 4 months ago

Also, for point 1. - PhotoUnpreparedView may be used somewhere else in future, that's why I wanted to keep it in separate component. Also it would need to be converted to a screen, as we need header feature + navigation. If it's okay for you to leave it like this, please re-review and lmk if you'd like to change anything else before I merge it.

CDFN commented 4 months ago

Ah, just remembered, in #385 there's more code in that screen (bottom sheet mainly)

CDFN commented 4 months ago
image

after your commit with isPending I'm still getting type error. But I'll take it as some kind of bug in ts server on my side.