search

digidem / comapeo-mobile

The next version of Mapeo mobile
GNU General Public License v3.0
5 stars 0 forks source link

feat: Show individual track #412

Open ErikSin opened 1 month ago

ErikSin commented 1 month ago

Shows individual track. Can be navigated to by clicking the track in an observation list and by clicking the track on the map

image
ErikSin commented 2 weeks ago

haven't looked closely at the changes related to the individual observation view

yeah...that shouldnt be there. Im looking now as to why that was added

ErikSin commented 2 weeks ago

haven't looked closely at the changes related to the individual observation view

yeah...that shouldnt be there. Im looking now as to why that was added

Nevermind, its not actually edits to observations. I just took the < Buttons/ > component from observations and made it into a reusable component, so the tracks screen could use it. Because of that, I had to move the logic into the observation component. So there shouldn't be any new code introduced to the observations screen.

ErikSin commented 1 week ago

I don't actually thing bbox makes sense to use here. bbox would really only give the unadjusted bounding box. And then we would need to adjust the bounding box based on the MIN_BOUND_SIZE. To me, bbox would make sense if we didnt have to check and adjust the size because it would simplify the code, but since we are doing so much manual manipulation it feels like an unnecessary import.

achou11 commented 1 week ago

I don't actually thing bbox makes sense to use here. bbox would really only give the unadjusted bounding box. And then we would need to adjust the bounding box based on the MIN_BOUND_SIZE. To me, bbox would make sense if we didnt have to check and adjust the size because it would simplify the code, but since we are doing so much manual manipulation it feels like an unnecessary import.

yeah that's fair. i think my argument for using the libraries is that you have to calculate the initial bounding box anyways, so it would be preferable to use something that's actually tested and provides confidence that it does it correctly. otherwise, i have to make sure that the custom bounding box calculation and the adjustment code are doing what's expected. for me, it results in less cognitive overload, which i think is generally worth it for highly specialized code