digidem / comapeo-mobile

The next version of Mapeo mobile
GNU General Public License v3.0
5 stars 0 forks source link

fix: properly detect and copy Intel-based native prebuilds when building apk #443

Open achou11 opened 1 week ago

achou11 commented 1 week ago

See patch comments and readme entry for full explanation, but basically some nodejs-mobile-react-native gradle steps were trying to find native prebuild directories that didn't exist due to slight naming discrepancies. This adds a patch to the gradle file, which I think is an easier (and maybe more appropriate?) solution than updating the configuration for all of the prebuild repos that we manage.

The original context for this PR can be found in #446 , but basically this is a relatively non-urgent PR because we decided to only build for arm (will happen in a separate PR). however, i think this is still good to have because it's one of those things that very easy to forget in the future, in case we decide to revisit introducing intel builds