search

digidem / leaflet-bing-layer

Bing Maps Layer for Leaflet v1.0.0
http://digidem.github.io/leaflet-bing-layer/
87 stars 53 forks source link

use https rather than http for the returned imageUrl #6

Closed tomgasson closed 7 years ago

tomgasson commented 8 years ago

Even though the metadata URL is called via https:// from #4, it still returns a http:// imageURL. Here I'm just find-replacing that url. Could also strip it back to a protocol relative url, but that's now ill-advised (see the update here).

cedricr commented 8 years ago

@tomgasson alternatively, check my comment on https://github.com/gmaclennan/leaflet-bing-layer/commit/408f43e18ac800eedbbbb3bec4072dd120974f22

tomgasson commented 8 years ago

Yep, that's a better way to do it. Code updated to suit

ggl commented 7 years ago

You could use location.protocol instead of hardcoding the scheme.

jengeb-rbb commented 7 years ago

It would be great if this PR could get integrated into master.

gmaclennan commented 7 years ago

@tomgasson thanks for this, so sorry for the delay, I haven't been checking these repos for a while.