digidem / leaflet-side-by-side

A Leaflet control to add a split screen to compare two map overlays
http://lab.digital-democracy.org/leaflet-side-by-side/
MIT License
351 stars 111 forks source link

Add multilayer support #23

Open asola-bi4group opened 6 years ago

asola-bi4group commented 6 years ago

I've improved the support for multiple layers in each side of the divider, because it was only updating the clip of one of the layers.

Now the divider circular button doesn't propagate the click event. It was firing the map click event while moving the divider, that in my opinion it makes no sense.

Any suggestion to the changes that I've made is welcome! :)

GSansigolo commented 3 years ago

We were having a problem working with multilayers on each side and this update solved our problem. I recommend that this PR be accepted.

tkempken commented 2 years ago

Please accept this PR I can also confirm multilayer issues to be resolved afterwards. IMHO this will fixes digidem/leaflet-side-by-side#37 and digidem/leaflet-side-by-side#37

sefo commented 1 year ago

Please do not accept this PR. Tried it leaflet 1.9.4 (replaced getContainer with getPane) Range events are broken and no layer is displayed.