search

digidem / mapeo-core-next

The upcoming version of Mapeo Core
MIT License
7 stars 1 forks source link

Should members who have left a project be listed as members in end-user APIs? #431

Open achou11 opened 5 months ago

achou11 commented 5 months ago

Description

We implemented project.leave() which updates a project member's role to LEFT. There's an open question as to whether listing these members when calling MemberAPI.getMany() should omit them by default (currently they're included).

Potential suggestion is to omit them by default and include an option for the method e.g. includeLeft that would include them as an opt-in behavior. Similar thing for blocked members.

gmaclennan commented 5 months ago

Yeah I'm not sure what's best, it depends on what feels most intuitive when using the API in the front-end. Open to this being whatever works best for @achou11 and @ErikSin. However if we are going to start adding a filter option to getMany() for other data types, it might start to be confusing if there is a "default" filter. On the other hand we already default to filtering out "deleted" records from getMany().