search

digidem / mapeo-core-next

The upcoming version of Mapeo Core
MIT License
7 stars 1 forks source link

chore: move `@digidem/types` package to devDependencies #631

Closed EvanHahn closed 1 month ago

EvanHahn commented 2 months ago

This change is not urgent.

This change should have no user impact.

This is a types-only dependency. We don't need it in production.

achou11 commented 2 months ago

would consult @gmaclennan on this one since I'm pretty sure we included it as a normal dependency intentionally - something related to needing to include the types when you publish this as a package 🤔

EvanHahn commented 2 months ago

Looks like this was originally added in #125. I didn't see any discussion there, but I'm sure there's a good reason.

achou11 commented 2 months ago

Looks like this was originally added in #125. I didn't see any discussion there, but I'm sure there's a good reason.

not necessarily, could easily be misremembering 😅 kind of tedious, but maybe doing an npm pack and trying to consume the module in another project will confirm it?

gmaclennan commented 2 months ago

Yes I think the typescript docs or definitely typed has info about which type packages need to be included as dependencies (vs devDependencies) when publishing a package. Don't remember where that info is off the top of my head, but I think this needs to be a dep for types to work when consuming as a module. I may be wrong.

EvanHahn commented 1 month ago

Not going to investigate this.

Sorry to waste some time!