search

digidem / mapeo-core-next

The upcoming version of Mapeo Core
MIT License
7 stars 1 forks source link

chore: remove unused "device type" property from MapeoManager #665

Closed EvanHahn closed 1 month ago

EvanHahn commented 1 month ago

This change should have no impact.

This property was never used, so we can remove it.

achou11 commented 1 month ago

I'm wondering if this is highlighting something that's missing that should be implemented? Just looking through https://github.com/digidem/mapeo-core-next/issues?q=is%3Aissue+deviceType, seems like we definitely want to support this field for sending during discovery 🤔 perhaps there was a follow-up that never came to be?

EvanHahn commented 1 month ago

Yeah, that was my thinking too.