search

digidem / mapeo-core

Library for creating custom geo data and syncronizing via a peer to peer network
23 stars 2 forks source link

fix: properly close osm & emit close event #85

Closed okdistribute closed 4 years ago

okdistribute commented 4 years ago

This back ports fixes to close osm from v9.

Also fixes #82

okdistribute commented 4 years ago

Thanks for the review! The failures are expected, right?

hackergrrl commented 4 years ago

@okdistribute no, these failures look new! the last commit to v8 passed

hackergrrl commented 4 years ago

I looked into this and I saw two things:

  1. the 2nd lifecycle test calls "close" twice, which the code isn't set up to handle properly
  2. a lot of confounding issues are coming, I think, from the various race conditions in the sync tests

I suggest folding this change into #87, where I've integrated your work here and applied some more sync test fixes to get everything passing again. You ok if we close this?