search

digidem / mapeo-default-config

Default config (categories, icons, questions) for Mapeo Mobile
Other
2 stars 4 forks source link

feat:publish package as compressed file #38

Closed tomasciccola closed 8 months ago

tomasciccola commented 8 months ago

this should close #37 We should wait until this is merged and with a new version published

should this be a minor version or a breaking change? I'm thinking the latter since we basically are publishing in a different format

tomasciccola commented 8 months ago

I would like that the build and build:dist scripts weren't basically the same with the only difference being the output folder (build/ vs dist/), but haven't found a way to reuse that cleanly...

EvanHahn commented 8 months ago

Looks like CI is failing, but I'm good to merge once you fix that.

tomasciccola commented 8 months ago

On the last commit I've changed the GH workflow to run npm install instead of npm ci. I know that in a CI/CD environment we should run a clean install, but I don't know why the workflow fails with npm ci. It seems to complains with not finding mapeo-settings-builder (which is installed as a devDependency). I also tried to use the settings-builder as a regular dependency (cause maybe the NODE_ENV is production here...) but that doesn't seem to work either. @EvanHahn any ideas?? I'm not that well versed in GH CI

EvanHahn commented 8 months ago

Not sure...maybe try updating node-version here, too?

https://github.com/digidem/mapeo-default-config/blob/a0a2d39de1ec443b542c2600c5339c740c8cdf83/.github/workflows/build.yml#L88