search

digidem / mapeo-desktop

Local-first mapping and monitoring in remote environments
https://mapeo.app
GNU General Public License v3.0
261 stars 33 forks source link

Enabling Bing Streetside in Photo Overlays crashes Mapeo in Territory view #513

Closed rudokemper closed 2 years ago

rudokemper commented 3 years ago

Describe the bug When you turn on "Bing Streetside" in the "Photo Overlays" in the Map Data menu in Territory view, and pan around at a high zoom level (where you can add data to the map), it crashes Mapeo resulting in a white screen that stays until you either reload the page or restart the app.

Can you do the same thing twice? The exact steps to see the problem again.

  1. Go to Territory View in Mapeo Desktop.
  2. Click on Map Data button and turn on "Bing Streetside"
  3. Zoom to a high level where you can start to add/edit data.
  4. Pan around the map for a while.
  5. See error

In addition, "Bing Streetside" stays toggled on even after closing and restarting Mapeo, which is how this could suddenly trip somebody (like me) up -- it stayed turned on after an experimentation session.

Bugsnag error as reported in web dev tools is as follows;

bugsnag] Uncaught exception, the process will now terminate…
TypeError: jsonpCache.QFToYyKIXarCXCp is not a function
    at https://dev.virtualearth.net/mapcontrol/HumanScaleServices/GetBubbles.ashx?appkey=AuftgJsO0Xs8Ts4M1xZUQJQXJNsvmh3IV8DkNieCiy3tCwCUMq76-WpkrBtNAuEm&c=2000&e=34.67880993932746&jsCallback=jsonpCache.QFToYyKIXarCXCp&n=1.0018921892627375&s=0.9980085272366057&w=34.67492568576869:1:12
(anonymous) @ C:\Users\rkemper\AppData\Local\Programs\mapeo-desktop\resources\app.asar\node_modules\@bugsnag\node\dist\bugsnag.js:1724
(anonymous) @ C:\Users\rkemper\AppData\Local\Programs\mapeo-desktop\resources\app.asar\node_modules\@bugsnag\node\dist\bugsnag.js:2121
(anonymous) @ C:\Users\rkemper\AppData\Local\Programs\mapeo-desktop\resources\app.asar\node_modules\@bugsnag\node\dist\bugsnag.js:1340
_cb @ C:\Users\rkemper\AppData\Local\Programs\mapeo-desktop\resources\app.asar\node_modules\@bugsnag\node\dist\bugsnag.js:1615
(anonymous) @ C:\Users\rkemper\AppData\Local\Programs\mapeo-desktop\resources\app.asar\node_modules\@bugsnag\node\dist\bugsnag.js:1630
(anonymous) @ C:\Users\rkemper\AppData\Local\Programs\mapeo-desktop\resources\app.asar\node_modules\@bugsnag\node\dist\bugsnag.js:1583
(anonymous) @ C:\Users\rkemper\AppData\Local\Programs\mapeo-desktop\resources\app.asar\node_modules\@bugsnag\node\dist\bugsnag.js:1598
emit @ events.js:205
EventEmitter.emit @ domain.js:471
endReadableNT @ _stream_readable.js:1154
processTicksAndRejections @ internal/process/task_queues.js:84

Expected behavior Mapeo does not crash when panning with "Bing Streetside" on. And, Mapeo clears "Bing Streetside" after one session, and returns to being turned off by default. And... maybe just maybe, we get rid of Photo Overlays as a whole as it doesn't seem useful to most (or any?) Mapeo users.

Screenshots image

Desktop:

Mapeo Version:

Additional context This beckons a broader discussion about cleaning up the Mapeo Territory view that @aliya-ryan and I have been considering. To my perception, most of Map Data is not really useful, or requires more work to render it useful. For training purposes, we generally have to tell people to just ignore this section. Perhaps we hide .map-data-control for now?

rudokemper commented 2 years ago

We resolved this in PR https://github.com/digidem/mapeo-desktop/pull/524 by hiding Photo Overlays as a whole, since it is not a useful iD feature for Mapeo. So closing this issue for now. 👀 @ximenabb