digidem / mapeo-map-server

Offline map style and tile server
MIT License
5 stars 2 forks source link

Upstream url for a tileset is not saved when creating it based on a style's sources #63

Closed achou11 closed 2 years ago

achou11 commented 2 years ago

when creating a style, we attempt to create new tilesets based on the style's sources field. When processing a tileset that is not yet persisted in the db, we don't pass the upstream url from which we obtained the tilejson:

https://github.com/digidem/mapeo-map-server/blob/eb1c2d913efc861494563a1e18b7cc2450301bdd/src/api/styles.ts#L206

as a result, future fetches of the tileset wont attempt to make upstream requests because that upstream url is nowhere to be found in our db:

https://github.com/digidem/mapeo-map-server/blob/eb1c2d913efc861494563a1e18b7cc2450301bdd/src/api/tilesets.ts#L145-L147

this will require the createTileset method to accept the upstream url as an optional parameter, which should be a straightforward fix