digidem / mapeo-mobile

Monitor and document the world around you
GNU General Public License v3.0
95 stars 16 forks source link

fix: fix build issues caused by jcenter shutdown #1035

Closed achou11 closed 1 year ago

achou11 commented 1 year ago

Looks like jcenter has finally been shutdown and as a result, certain deps that we use don't work without some intervention. This PR does the following:

  1. updates the build config to strip android dep references to the jcenter repository (see https://github.com/facebook/react-native/issues/35136 for context)
  2. removes jcenter repo from our build config
  3. adds necessary extra configuration for @react-native-mapbox-gl/maps in order to pull certain Mapbox SDK deps from their password-protected repo.
  4. removes an unused dep (react-native-build-config)

re: 3, i'm a little hesitant about this because:

ideally, these would be a temporary measure and we'd update our usage of the library to use the MapLibre SDK, which i believe doesn't have these limitations (they publish to Maven Central).

for additional context, I think if https://github.com/mapbox/mapbox-gl-native-android/issues/650 and https://github.com/mapbox/mapbox-gl-native-android/issues/630 were addressed, then maybe we wouldn't need the additional config steps, but not entirely sure if the accounts dep is the only problematic one

TODO BEFORE MERGING:

achou11 commented 1 year ago

Based on brief internal discussion, we should look into just switching to MapLibreGL.

achou11 commented 1 year ago

Update: decided that for now we'll just move forward with the secret token nonsense because we're not in a position to attempt to switch over to MapLibreGL just yet. It's something we're definitely interested in doing later on and we should open an issue that references this PR in order to fully understand the context for doing so