digidem / mapeo-mobile

Monitor and document the world around you
GNU General Public License v3.0
95 stars 16 forks source link

Fix alert sharing via Signal #1046

Open ximenabb opened 1 year ago

ximenabb commented 1 year ago

Description

As reported : https://www.notion.so/digidem/Fix-alert-sharing-via-Signal-10bb6ce247f84a5188a07eda4d197fd1

Problem:

Users can no longer share observations via Signal.

When selecting the Signal app to share an observation, the Share bottom sheet closes and Mapeo raises a Could not get share data from intent error.

Bug Report Details

Mapeo Mobile 5.4.7 on OnePlus 6T, Android 11

Signal 6.0.6

Observed by: ER

Describe the bug When selecting the Signal app to share an observation, the Share bottom sheet closes and Mapeo raises a Could not get share data from intent error.

Can you do the same thing twice? The exact steps to see the problem again.

  1. Go to View Observation screen
  2. Click on Share
  3. Select Signal on bottom sheet
  4. See error within Mapeo

Screenshots

Screenshot_20221110-122138

User Goal:

ErikSin commented 1 year ago

Update:

This issue is only happening when the observation has an image/images attached to it.

The issue lies with Signal app, it seems to not be reading the Android Intent when it has a file associated. See Receiving simple data from other apps

I attempted to change the file to base64, but that did not fix the problem.

I looked into changing the library we use to share images. The only other Viable option is expo-sharing, but that only allows 1 image to be shared, and no associated message.

I am going to see if I can find the problem in the Signal Codebase, but I have very limited java skills...so we will see.