search

digidem / mapeo-mobile

Monitor and document the world around you
GNU General Public License v3.0
95 stars 16 forks source link

fix: fix issues with BottomSheetModal implementation #1083

Open achou11 opened 1 year ago

achou11 commented 1 year ago

A couple of issues that are fixed:

  1. The backdrop didn't overlap the native navigation header, which meant that interaction with that header was not blocked, allowing things like going back to a previous screen when the modal was opened. Now it overlaps the header and prevents interaction there, as desired.

    • Before:

      image

    • After:

      image

  2. When on a screen that contains the BottomSheetModal, the default disabled back behavior via Android's hardware back button was active even though the modal was closed. Now the disabled back behavior is disabled only when the modal is open

ErikSin commented 1 year ago

Closes #1082

ErikSin commented 1 year ago

@achou11 Im not going to include this in the upcoming release. It touches more parts than we QA. So for the time being, I am going to merge this PR , which is a repeat of your work (but scoped to the one modal). For the next release, we can add this PR, and QA all the modals.

achou11 commented 1 year ago

@ErikSin any interest in revisiting this to get it merged for next release?