digidem / mapeo-mobile

Monitor and document the world around you
GNU General Public License v3.0
95 stars 16 forks source link

fix: fix sharing of observation on Android 12+ #1098

Closed achou11 closed 1 year ago

achou11 commented 1 year ago

Fixes #1097

Notes:

  1. Create observation that has an attachment (e.g. photo)
  2. Open observation screen
  3. Press Share button
achou11 commented 1 year ago

~noticing that the preview isn't showing up in the share menu. can't remember if that's expected or not but guessing it's not because it shows up in the case where there's no attachments present.~

Screen Shot 2023-05-22 at 4 41 23 PM

~seeing the same thing as https://github.com/react-native-share/react-native-share/issues/613 in adb logs - wondering if that's related. not really sure how to fix, but this doesn't seem to actually break the sharing itself, so hopefully not a major blocker for this PR~

UPDATE: this is not a regression as this is the previously observed behavior for observations without attachments, so please ignore this comment 😄

achou11 commented 1 year ago

Closing in favor of #1099