search

digidem / mapeo-mobile

Monitor and document the world around you
GNU General Public License v3.0
95 stars 16 forks source link

P2P Upgrade Issues #948

Open ximenabb opened 2 years ago

ximenabb commented 2 years ago

Description: Initial conversation with videos here : https://digidem.slack.com/archives/C0P5VH7MK/p1648048729427319 Unable to to P2P upgrade from 5.4.1 to 5.4.2.

Todo: Attempt to replicate the issue by following Jen's instruction. Share findings with the programs team. Important to note we should attempt to fix before Jen's trop first week of May for PUINAMUDT

ximenabb commented 2 years ago

@jencastrodoesstuff for visibility. feel free to add additional info.

achou11 commented 2 years ago

Update: attempted to try this again using the v5.4.3 from the Play Store. Still didn't work but here's a breakdown of repro steps:

  1. Using 2 devices

    • Pixel 2 on Android 11, with Mapeo v5.4.1 installed via direct APK
    • Pixel 6 on Android 12, with Mapeo v.5.4.3 installed via Google Play
    • Both support the same device ABIs
    • armeabi-v7a (32-bit), arm64-v8a (64-bit)

  2. Attempted p2p update but the Pixel 6 immediately displayed an error about being unable to check for updates. From the related Bugsnag error, @gmaclennan believes it's an issue with noderify + fastify:

ok great, that's the bug. I remember seeing something like this and I thought we had a fix. Because we are building with noderify, require does not have the property cache (because noderify injects its own implementation of require. Fastify is looking at this require.cache property to do something clever with plugins.

yeah this was patched but must be something new slipping through or the patch failed to apply: https://github.com/digidem/mapeo-mobile/blob/develop/src/backend/patches/avvio%2B7.2.2.patch

aha, warning in build logs: npm WARN lifecycle [REDACTED]-node@1.0.0~postinstall: cannot run in wd [REDACTED]-node@1.0.0 patch-package (wd=/bitrise/src/nodejs-assets/backend)

ErikSin commented 2 years ago

Update from @jencastrodoesstuff

Device had upgraded from 5.4.1 => 5.4.2 using the p2p upgrader. Seemed to work fine.

After opening device again, device downgraded back to 5.4.1:

https://files.slack.com/files-pri/T03NDM68K-F03D27297U7/screenshot_20220428-154626_mapeo.jpg