search

digidem / osm-p2p-db

Peer-to-peer database for OpenStreetMap data
BSD 2-Clause "Simplified" License
237 stars 25 forks source link

Include changeset id in deletion #35

Closed gmaclennan closed 7 years ago

gmaclennan commented 7 years ago

@noffle could you review and add a test here (see the failing test in osm-p2p-server https://github.com/digidem/osm-p2p-db/compare/changeset-deletions) attempts to fix #34

hackergrrl commented 7 years ago

What do you think about just having fields.v set to opts.value directly? This makes it more versatile for the future.

gmaclennan commented 7 years ago

That makes sense to me. I'm not sure about @substack's original motivation for choosing this API.

hackergrrl commented 7 years ago

Can you also update the osm.del() calls we make to set opts.value.changeset?

hackergrrl commented 7 years ago

Let's nix this PR and update osm-p2p-db#del() to accept a value on deletions, just like PUTs, like we discussed in meatspace.

gmaclennan commented 7 years ago

closing in favour of https://github.com/digidem/osm-p2p-db/pull/46