search

digidem / osm-p2p-server

Peer-to-peer OpenStreetMap API v0.6 Server for osm-p2p-db
BSD 2-Clause "Simplified" License
87 stars 10 forks source link

updated to use kappa-osm #38

Closed ghost closed 5 years ago

ghost commented 5 years ago

This patch updates the module to work with kappa-osm, pending these other PRs:

I had to skip the ghost point test cases because they appear to trigger an upstream replication issue in multifeed where the replication stream never finishes. Everything else works.

codecov-io commented 5 years ago

Codecov Report

Merging #38 into master will decrease coverage by 3.82%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #38      +/-   ##
=========================================
- Coverage   87.62%   83.8%   -3.83%     
=========================================
  Files          28      28              
  Lines         679     673       -6     
=========================================
- Hits          595     564      -31     
- Misses         84     109      +25
Impacted Files Coverage Δ
routes/changesets.js 33.33% <ø> (-16.67%) :arrow_down:
api/get_changes.js 82.92% <100%> (-9.58%) :arrow_down:
lib/filter_deletes.js 85.91% <100%> (-5.87%) :arrow_down:
api/get_element.js 81.08% <100%> (-1.85%) :arrow_down:
api/put_changes.js 95.83% <100%> (ø) :arrow_up:
api/close_changeset.js 80% <0%> (-20%) :arrow_down:
lib/util.js 82.05% <0%> (-15.39%) :arrow_down:
api/create_element.js 85.71% <0%> (-14.29%) :arrow_down:
lib/replace_ids.js 88.88% <0%> (-11.12%) :arrow_down:
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 16aef2f...221c16c. Read the comment docs.

hackergrrl commented 5 years ago

Made a couple of tweaks to get tests passing (package.json bump), but looks great! Thank you @substack! I'll try to get the ghost node tests passing in another PR. :gem: