digidem / osm-p2p-server

Peer-to-peer OpenStreetMap API v0.6 Server for osm-p2p-db
BSD 2-Clause "Simplified" License
87 stars 10 forks source link

node attributes should also contain a version #41

Closed okdistribute closed 4 years ago

okdistribute commented 5 years ago

Although it wasn't tested, the last version of osm-p2p-server's map?bbox route would return nodes that had a version property. For example,

  changeset: '3142142805352922006',
  lat: 64.98,
  lon: -121.98,
  timestamp: '2019-03-29T19:56:02.654Z',
  id: '9668467094617189336',
  version:
   '03f23d77b9c37692f66657b2c2f1e8e87e522c197f3e12f1d4d4c4aea6bec07c' }

This PR adds a test that ensures nodes have attributes that contain a version.

codecov-io commented 5 years ago

Codecov Report

Merging #41 into master will increase coverage by 0.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #41      +/-   ##
==========================================
+ Coverage    85.9%   85.92%   +0.01%     
==========================================
  Files          30       30              
  Lines         759      760       +1     
==========================================
+ Hits          652      653       +1     
  Misses        107      107
Impacted Files Coverage Δ
api/get_map.js 85% <100%> (+0.25%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f5553e5...f3eb3df. Read the comment docs.