search

digidem / react-mapfilter

Visualizing, exploring, filtering and printing geographic data and geotagged photos and video
https://lab.digital-democracy.org/mapfilter
29 stars 11 forks source link

fix: Fix number fields to always return number not string #103

Closed gmaclennan closed 4 years ago

gmaclennan commented 4 years ago

Previously the field for a field of type number was returning the number formatted as a String. This fix ensures that the a number field always sets a number value, or undefined if the value of the field is not a valid number.

I don't think we are using number type fields much in "the wild" but best to ensure this is working as expected while we remember.

TODO: Check behaviour of number fields in Mapeo Mobile.

okdistribute commented 4 years ago

@gmaclennan is this blocking on 'TODO: Check behaviour of number fields in Mapeo Mobile.' or should we merge to make it into next Desktop release?

gmaclennan commented 4 years ago

It's not blocking, I added an issue https://github.com/digidem/mapeo-mobile/issues/423. Let's merge this and get it into the next Desktop release.